[getdns-users] [PATCH] remove GETDNS_COMPILATION_COMMENT

[Robert Edmonds]

Melinda Shore wrote:
> On 7/8/15 9:58 AM, Hollenbeck, Scott wrote:
> > I'm currently using GETDNS_COMPILATION_COMMENT in the PHP language
> > bindings to display the getdns library version used to build the PHP
> > extension. If GETDNS_COMPILATION_COMMENT goes away is there another
> > way of retrieving the getdns library version information at
> > compilation time?
> 
> Yes, you can pull version_string out of what's returned by
> context_get_api_info().  That's what I'm doing in the Python
> bindings.

Looking at the version-related stuff in http://www.vpnc.org/getdns-api/,
I'm a bit confused.  The 'version_string' field in the dict returned by
getdns_context_get_api_information() is defined as:

    version_string (a bindata) represents the version string for this
    version of the DNS API.

That's the version of the getdns API, right?  Which is supposed to be
something like "getdns February 2014".  But in getdns (argh, the
"getdns" implementation, not the "getdns API"), that field is set to
something like (in hexadecimal notation) 30 2E 32 2E 30 00 (i.e., the
NUL-terminated C string "0.2.0"), which is the getdns PACKAGE_VERSION
value.

Shouldn't the version of the API rather than the implementation be
returned in version_string?  That seems to be implied by the function
being called getdns_context_get_*api*_information().

-- 
Robert Edmonds
edmonds at debian.org