[getdns-users] First candidate for getdns-1.7.0 and stubby-0.4.0

[A. Schulze]

Am 28.05.21 um 13:01 schrieb Willem Toorop via Users:
> Dear all,
> 
> We finally have a first candidate for a new 1.7.0 release of getdns.

Hello Willem,

I built getdns on Debian 10 and noticed some different classes of warnings:

1. looks like "ATTR_UNUSED" don't work as expected
/<<PKGBUILDDIR>>/src/gldns/gbuffer.h:159:50: warning: unused parameter ‘buffer’ [-Wunused-parameter]
gldns_buffer_invariant(gldns_buffer *ATTR_UNUSED(buffer))
                                                  ^
/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/config.h:458:27: note: in definition of macro ‘ATTR_UNUSED’
#  define ATTR_UNUSED(x)  x
                           ^
this warning occur 26 times

2.
/<<PKGBUILDDIR>>/src/util-internal.c: In function ‘_getdns_rr_iter2rr_dict_canonical’:
/<<PKGBUILDDIR>>/src/util-internal.c:306:4: warning: ‘val_type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    switch (val_type) {
    ^~~~~~

3. non masked unused parameter
/<<PKGBUILDDIR>>/src/rr-dict.c: In function ‘ipseckey_gateway_2wire’:
/<<PKGBUILDDIR>>/src/rr-dict.c:216:43: warning: unused parameter ‘rdata’ [-Wunused-parameter]
     const getdns_bindata *value, uint8_t *rdata, uint8_t *rdf, size_t *rdf_len)
                                  ~~~~~~~~~^~~~~
/<<PKGBUILDDIR>>/src/rr-dict.c: In function ‘amtrelay_relay_2wire’:
/<<PKGBUILDDIR>>/src/rr-dict.c:580:43: warning: unused parameter ‘rdata’ [-Wunused-parameter]
     const getdns_bindata *value, uint8_t *rdata, uint8_t *rdf, size_t *rdf_len)
                                  ~~~~~~~~~^~~~~

4. spelling errors
spelling-error-in-manpage usr/share/man/man3/getdns_general.3.gz satisifed satisfied
spelling-error-in-manpage usr/share/man/man3/getdns_general_sync.3.gz satisifed satisfied

so far my report without running stubby yet :-)

Andreas