[getdns-api] timeouts specified as milliseconds rather than seconds

[Matthew A. Miller]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512


On 2/20/14, 2:25 PM, Goyal, Neel wrote:
> We could then use uint32_t - I think uint16_t maxing @ 65 seconds is too
> little, though if that timeout is ever hit, then there are probably other
> issues at play.  Maybe uint64_t is overkill and uint32_t suffices.
>
> On 2/20/14, 4:17 PM, "Melinda Shore" <melinda.shore at nomountain.net> wrote:
>
>> On 2/20/14 11:47 AM, Wiley, Glen wrote:
>>> Since we are making this milliseconds does anyone object to making the
>>> type a uint64_t ?
>>
>>
>> Well, double-checking my arithmetic my previous response was overly
>> dramatic:
>> 2^33 milliseconds = 8589934592 milliseconds or about 99 days.  But I
>> still question whether or not that kind of timeout is really necessary.
>>
>>
I think uint64_t is definitely overkill.

I think uint32_t probably the safer choice, but I have doubts that
anything larger than fits in uint16_t will be seen in the wild.

- -- 
- - m&m

Matthew A. Miller
< http://goo.gl/LK55L >
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTBnemAAoJEOz0ck4QngW721wIAJcQmqzR4IRqoghJnlgzQQzW
oTtyaM3ts8OnB+jD9QoQvSK2OUK//1vtzYMH9efKnqpHewoz25vLHpNh4hfAxYVG
6GWBb04+NWt3INfm6hkX+wVz+1qYh3OAPmhiiIdSnYcEm5+2NGVMkVhklkGu+SKj
3Rdlw9yGs3EU9DayRmbcdt9IVJxtTUqGUsoqVlyiMd/eXMjknaeF3/PZ89nD4Shw
Hq+RwP5m8wo1vTHMiWcDU5k1gFq0caQME18zv8DmNdPUM3OHVg8fMGNCNAl61xZX
Bumq6pFsHhZt25Rtn0AEDY2LZrr9BI2g90XpqAtjCgLLvfI4jWpo1wNIFAvHDrU=
=2vg7
-----END PGP SIGNATURE-----